Remove scripts from source code distribution
#2593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update path to script in corresponding action Fix pvlib#2520
kandersolar
approved these changes
Nov 12, 2025
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
The pytest failures seem unrelated; likely just some bugginess in the new pytest 9.0.0 release.
The dist files here look good: https://github.com/pvlib/pvlib-python/actions/runs/19120247537?pr=2593
Thanks @josephradford!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move top ranking script to .github/workflows
Update path to script in corresponding action
scriptsmay need to be excluded inMANIFEST.inif the empty folder persists. However, it seems to be working OK now, but happy to add if needed.scriptsfrom source code distribution #2520[ ] Tests addedN/A[ ] Updates entries inN/Adocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file ininternal infrastructure shouldn't be included in whatsnewdocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.N/Aremote-data) and Milestone are assigned to the Pull Request and linked Issue.